Provide more specific file type descriptions on macOS

[Tanner Bennett (NSExceptional)]

Motivation and Summary of Changes

Right now, VS Code defines the file type description for every file association it creates as "VS Code document", which is not very useful. The file type description is what appears in the Info pane for a file in Finder:

This PR aims to 1) make it possible to specify specific names at all, and 2) to provide some default names for most of the existing supported file types.

My commit messages and code documentation have more detailed information on the approach I took to this.

Oh, also, I could not for the life of me figure out how to get these changes to build. I ran yarn compile inside build/ and it built the *.js files, but could not get the results published in the final product. If someone can tell me how to do that, I will test it on my machine to ensure it works as expected.

PR Checklist

• There is no issue associated with this PR, because I just started on a PR first instead of making an issue.
  Do I need to create an issue anyway?

• I have read through the coding guidelines and I think the only guideline I may be breaking is this one:

  Do not introduce new types or values to the global namespace

  However, I'm not sure where to put the two new types I declared. I need some direction here if my PR cannot be merged because of this.

[Deleted user (ghost)]

All CLA requirements met.

[Tanner Bennett (NSExceptional)]

Fixed the build errors, but still haven't actually been able to test it

[João Moreno (joaomoreno)]

PR Checklist

• There is no issue associated with this PR, because I just started on a PR first instead of making an issue.
  Do I need to create an issue anyway?

Yeah let's create one.

• I have read through the coding guidelines and I think the only guideline I may be breaking is this one:

  Do not introduce new types or values to the global namespace

  However, I'm not sure where to put the two new types I declared. I need some direction here if my PR cannot be merged because of this.

You're good here, no worries. 👌

Oh, also, I could not for the life of me figure out how to get these changes to build. I ran yarn compile inside build/ and it built the *.js files, but could not get the results published in the final product. If someone can tell me how to do that, I will test it on my machine to ensure it works as expected.

You'll be able to build an OSS version of VS Code with yarn gulp vscode-darwin, let me know how that goes.

[João Moreno (joaomoreno)]

Tanner Bennett (@NSExceptional) I'll set the PR to draft until you've tested and we're ready for a review.

[Tanner Bennett (NSExceptional)]

João Moreno (@joaomoreno) No dice, it builds without errors then fails to run :/

Screenshots

Is it possible I messed something up while snooping around in the OSS build folder? I tried yarn cache clean hoping that would blow away any build artifacts but I'm not sure if it does that

[João Moreno (joaomoreno)]

Try rm -r .build, that will clean the local electron build, so it fetches a new one.

[Tanner Bennett (NSExceptional)]

That did the trick. It worked! Here's the generated Info.plist

[Tanner Bennett (NSExceptional)]

Noticed there were no associated file extensions in my screenshot 🤪 Fixed; I was indexing the object improperly in darwinBundleDocumentTypes:

function darwinBundleDocumentTypes(types: { [name: string]: string | string[] }, … {
    return Object.keys(types).map((name: string, idx: number): DarwinDocumentType => {
        const extensions = types[idx]; // <-- using idx by mistake
        ...

→

function darwinBundleDocumentTypes(types: { [name: string]: string | string[] }, … {
    return Object.keys(types).map((name: string): DarwinDocumentType => {
        const extensions = types[name]; // <-- use name instead
        ...

[Tanner Bennett (NSExceptional)]

Compilation is now failing here because of src/vs/workbench/test/browser/api/extHostBulkEdits.test.ts passing an extra argument to a function, but I didn't touch that file or any related files? 😟

[Tanner Bennett (NSExceptional)]

João Moreno (@joaomoreno) Do you know what's going on? I need some guidance

[João Moreno (joaomoreno)]

Just merge main into your branch and let's see if CI gets over that hump.

[Tanner Bennett (NSExceptional)]

No wonder, I was rebasing on my local main which was tracking my fork, not upstream 🤦🏻‍♂️

[Tanner Bennett (NSExceptional)]

João Moreno (@joaomoreno) All checks passed!

[Tanner Bennett (NSExceptional)]

João Moreno (@joaomoreno) does this have any blockers?

[Tanner Bennett (NSExceptional)]

João Moreno (@joaomoreno) will this be put into the May milestone?

[João Moreno (joaomoreno)]

Thanks! 🍻