Add Copy Command Label to Keyboard Shortcuts.

[Tim Fenney (timfenney)]

This PR fixes #125092.

[Deleted user (ghost)]

All CLA requirements met.

[Tim Fenney (timfenney)]

Sandeep Somavarapu (@sandy081) did you get time to take a l:eyes:k at this yet?

[Sandeep Somavarapu (sandy081)]

Instead of context menu can you please make the text selectable?

[Tim Fenney (timfenney)]

Instead of context menu can you please make the text selectable?

It is a good idea! What way should it be selectable? The UI already allows:

• single click to select row
• double click to add keyboard shortcut

...for this reason, I am not sure what is a good UX here. What do you think Sandeep Somavarapu (@sandy081) 🤔 ?

Also, we have 2 ways of copying aspects of the command via context menu already. Is it orthogonal to have a 3rd way of copying something from the command somewhere else?

Alternatively, what do you think of adding a copy button? I am not sure it belongs in the action buttons at the beginning of the row, but could go inside the td with the label.

[Sandeep Somavarapu (sandy081)]

Please ignore my previous comment. After thinking more I felt initial approach of providing the copy command in the context menu makes sense. Please let me know if the changes with context menu option are ready for review.

[Tim Fenney (timfenney)]

Sandeep Somavarapu (@sandy081) it is ready for review 👍

[Sandeep Somavarapu (sandy081)]

LGTM