platform/configuration: fix empty keys being ignored by configuration parser - #128909
Merged
Conversation
Contributor
Author
|
I also have a unit test ready to go, if you'd like me to add it to the PR. |
Member
|
Thanks for the PR. I will take a look at it after validating the issue. |
Sandeep Somavarapu (sandy081)
self-requested a review
July 21, 2021 09:34
Member
|
Thanks for the changes and they LGTM. Please add the unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #126972.
I tested the change locally with my own extension (since I encountered #126972 in 71/dance#184), and it did fix it.