Voice: warm capture before hands-free playback - #328225
Merged
Megan Rogge (meganrogge) merged 6 commits intoJul 31, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 15eb9602-6daa-4c99-8455-0a20804e569a
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
Capture setup errors can be swallowed, and permission failures produce duplicate notifications.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Warms hands-free microphone capture before backend session initialization and improves reconnect and speech-turn handling.
Changes:
- Adds cancellable, shared microphone acquisition and smaller VAD-aligned chunks.
- Preserves reconnect intent and speech-start turn IDs.
- Expands voice lifecycle tests.
File summaries
| File | Description |
|---|---|
voiceSessionController.test.ts |
Tests warm-up, retries, timeouts, and speech interruption. |
voiceClientService.test.ts |
Tests turn IDs and reconnect state. |
micCaptureService.test.ts |
Verifies capture chunk duration. |
common/voiceClient/voiceClientService.ts |
Extends voice event and reconnect contracts. |
voiceSessionController.ts |
Adds pre-session microphone warm-up and reconnect handling. |
voiceClientService.ts |
Exposes reconnect scheduling and speech turn IDs. |
micCaptureService.ts |
Adds acquisition coordination, cleanup, and smaller chunks. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Copilot resolve the merge conflicts in this pull request |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1f93d2f2-660e-46e9-a869-98ce147905f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1f93d2f2-660e-46e9-a869-98ce147905f9
Megan Rogge (meganrogge)
enabled auto-merge (squash)
July 31, 2026 15:55
Megan Rogge (meganrogge)
approved these changes
Jul 31, 2026
Megan Rogge (meganrogge)
previously approved these changes
Jul 31, 2026
Vritant Bhardwaj (vritant24)
previously approved these changes
Jul 31, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d5f00f75-49d2-4b4f-a503-050b7b6a2f57
Megan Rogge (meganrogge)
dismissed stale reviews from Vritant Bhardwaj (vritant24) and themself
via
July 31, 2026 16:31
c94fbfe
Anthony Kim (anthonykim1)
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.