Skip to content

fix: globs in path if cwd is not the cfg file loc - #43

Merged
pawamoy merged 2 commits into
mkdocstrings:masterfrom
veghdev:glob_path_fix
Nov 19, 2022
Merged

fix: globs in path if cwd is not the cfg file loc#43
pawamoy merged 2 commits into
mkdocstrings:masterfrom
veghdev:glob_path_fix

Conversation

@veghdev

@veghdev veghdev commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

fix #42

based on the documentation: "Non-absolute paths are computed as relative to MkDocs configuration file."

@veghdev

veghdev commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

I did not use the glob.glob() root_dir argument because it is only available from python 3.10.

@veghdev

veghdev commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

@pawamoy Could you please review? Thanks

@pawamoy

pawamoy commented Nov 16, 2022

Copy link
Copy Markdown
Member

Sure, I will when I get some time :)
Thanks for the PR!

@pawamoy

pawamoy commented Nov 19, 2022

Copy link
Copy Markdown
Member

CI failures unrelated, will fix in another PR.

I took the liberty to modify your changes a bit, I hope you don't mind.

@pawamoy
pawamoy merged commit 0dc45ae into mkdocstrings:master Nov 19, 2022
@veghdev

veghdev commented Nov 19, 2022

Copy link
Copy Markdown
Contributor Author

I took the liberty to modify your changes a bit, I hope you don't mind.

No problem, I'm glad I could help and thank you for your review.

viktorlashchuk added a commit to viktorlashchuk/mkdocstrings-python that referenced this pull request Feb 24, 2025
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
Issue #42: mkdocstrings/python#42
PR #43: mkdocstrings/python#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

path does not working if cwd is not the cfg file location

2 participants