Skip to content

feat: Allow resolving alias to any external module - #61

Merged
pawamoy merged 1 commit into
mkdocstrings:masterfrom
gilfree:load_external_modules2
Mar 7, 2023
Merged

feat: Allow resolving alias to any external module#61
pawamoy merged 1 commit into
mkdocstrings:masterfrom
gilfree:load_external_modules2

Conversation

@gilfree

@gilfree gilfree commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This PR extends #60 to allow loading any external module

@pawamoy pawamoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a suggestion for the docs.Feel free to rephrase it again, I'm not the best technical writer.

Comment thread docs/usage.md Outdated
Comment thread src/mkdocstrings_handlers/python/handler.py Outdated
@gilfree
gilfree force-pushed the load_external_modules2 branch from 6574ace to 3082735 Compare March 6, 2023 09:57
@gilfree

gilfree commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Hi @pawamoy, I have rebased and update according to the changes you requested

@pawamoy pawamoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pawamoy
pawamoy merged commit 02052e2 into mkdocstrings:master Mar 7, 2023
@gilfree
gilfree deleted the load_external_modules2 branch March 7, 2023 19:28
@gilfree

gilfree commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

Hi @pawamoy.

Do you plan a release with these fixes in the near time?
Are you waiting to more features/fixes to accumulate or have some future release date in mind?

@pawamoy

pawamoy commented Mar 21, 2023

Copy link
Copy Markdown
Member

I'll try to release a new version tomorrow 🙂 Thanks for the reminder!

viktorlashchuk added a commit to viktorlashchuk/mkdocstrings-python that referenced this pull request Feb 24, 2025
PR #61: mkdocstrings/python#61
Follow-up of PR #60: mkdocstrings/python#60
Co-authored-by: gilfree <gilfree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants