Separated routing to nette/routing - #208
Merged
Merged
Conversation
Contributor
|
As long as |
dg
force-pushed
the
master
branch
2 times, most recently
from
February 5, 2019 15:16
f3e6c04 to
ea63826
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
February 10, 2019 17:46
10a5830 to
e402814
Compare
dg
force-pushed
the
routing
branch
2 times, most recently
from
February 10, 2019 18:24
b5a1731 to
5802d52
Compare
This was referenced Feb 11, 2019
dg
force-pushed
the
routing
branch
3 times, most recently
from
February 12, 2019 13:32
11f8f2f to
16a38c0
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 13, 2019 00:53
56c5e11 to
5919611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routers in nette/routing are pure, without any reference to concepts such as presenter / action. So they can't have:
Route('mask', 'Presenter:action'), onlyRoute('mask', ['presenter' => 'Presenter', 'action' => 'action'])moduleSo there are descendants in nette/application, which add this functionality.
The problem is that there are two classes in Nette like
Nette\Routing\RouteandNette\Application\Routers\Route(in a similar relationship likeNette\Forms\FormandNette\Application\UI\Form), which is not good. That's why I take this as a concept, not something ready to merge.