SQLiteJournal: filesystem permissions like ordinary file - #30
Merged
Conversation
Member
Author
|
I didn't find a more systematic way. |
milo
force-pushed
the
pull-29-permissions
branch
from
September 7, 2015 12:17
518aa60 to
b5a505f
Compare
Contributor
|
I don't like the |
|
What about if ($path !== ':memory:') {
touch($path);
} |
Contributor
|
@Unlink 👍 for EDIT: or maybe not, I don't know. |
Contributor
There was a problem hiding this comment.
What if fopen returns false?
Member
Author
|
Syscalls of solutions: |
Contributor
|
What about |
milo
force-pushed
the
pull-29-permissions
branch
from
October 17, 2015 20:22
b5a505f to
3f8a80b
Compare
milo
force-pushed
the
pull-29-permissions
branch
2 times, most recently
from
April 3, 2016 09:09
667fb80 to
73d31b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLiteJournal is used with the FileCache. Seems correct to me, it should behave in the same way as ordinary files.