Skip to content

Generated factory: nullable types support - #132

Closed
matej21 wants to merge 1 commit into
nette:masterfrom
matej21:feature/gen_factory_nullable
Closed

Generated factory: nullable types support#132
matej21 wants to merge 1 commit into
nette:masterfrom
matej21:feature/gen_factory_nullable

Conversation

@matej21

@matej21 matej21 commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 63106a2 on matej21:feature/gen_factory_nullable into ** on nette:master**.

@dg

dg commented Dec 21, 2016

Copy link
Copy Markdown
Member

@coveralls I have reported you as spam.

@TomasVotruba

TomasVotruba commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

@dg What about using Scrutinizer? It doesn't spam and doesn't report false negative on test when coverage is decreased.

I use it on every project and I'm very happy with that.

@dg

dg commented Dec 21, 2016

Copy link
Copy Markdown
Member

@matej21 it is not a correct solution, it will not work for example with function create(?string $title, ?Foo $foo, ?int $lorem = 1): Article;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants