Skip to content

strict fix - #249

Merged
dg merged 1 commit into
nette:masterfrom
dakorpar:patch-1
Jun 8, 2020
Merged

strict fix#249
dg merged 1 commit into
nette:masterfrom
dakorpar:patch-1

Conversation

@dakorpar

@dakorpar dakorpar commented Jun 8, 2020

Copy link
Copy Markdown
Contributor
  • bug fix
  • BC break? no

It breaked unit tests on project, not sure if it's only unit tests or also code related as well, but whenever I have container which name was numeric I'm getting exception:

TypeError : ReflectionClass::hasProperty() expects parameter 1 to be string, int given
 /var/www/vendor/nette/forms/src/Forms/Container.php:124

@mabar

mabar commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

I guess it's related to php casting numeric strings to integers in array keys

$arr['123'] = 'key is string';
var_dump($arr);

// Key is not string, php casted it to int
/*
array(1) {
  [123]=>
  string(13) "key is string"
}
*/

@dg

dg commented Jun 8, 2020

Copy link
Copy Markdown
Member

Thans

@dg dg changed the title Allways cast control name to string in getValues strict fix Jun 8, 2020
@dg
dg merged commit b4d63f4 into nette:master Jun 8, 2020
@dakorpar
dakorpar deleted the patch-1 branch June 8, 2020 19:51
@kravcik

kravcik commented Jun 19, 2020

Copy link
Copy Markdown

Is planned to tag this one in the near future?

@carloscz

carloscz commented Jul 7, 2020

Copy link
Copy Markdown

Is planned to tag this one in the near future?

+1 broken project :/ by 3.0.5 version

@Kocicak

Kocicak commented Jul 16, 2020

Copy link
Copy Markdown

Is planned to tag this one in the near future?

+1 broken project :/ by 3.0.5 version

+1 another broken project

@dg

dg commented Jul 16, 2020

Copy link
Copy Markdown
Member

3.0.6 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants