Fix "Session object destruction failed" - update

[luhla]

No description provided.

[luhla]

Sorry, have to study how run tests before pull request...

[hrach]

And try to fix the current one, not to open another :)

[enumag]

@luhla Maybe the session_write_close(); should be before the if. That should fix the failing test as well.

[luhla]

I did try it before, but result was also failed checks. Solution is session_write_close(); before session_regenerate_id(TRUE); in my case but I wouldnt do annoing tests here.

[dg]

Can you explain what is it good for?

[luhla]

Getting "session_regenerate_id(): Session object destruction failed" when calling before session_write_close();
But i can`t call session_write_close(); before session_id().

[dg]

Is it needed to call session_write_close() when session_id() === '' ?

Or now we can use http://php.net/manual/en/function.session-status.php

[luhla]

Getting error when using:

if (session_id() !== '') {
        session_regenerate_id(TRUE);
}

Everithing fine when using:

if (session_status() === PHP_SESSION_ACTIVE ) {
        session_regenerate_id(TRUE);
}

[dg]

IMHO session_write_close(); should be in condition too.

[dg]

Did you change the order of session_write_close and session_regenerate_id intentionally?

[luhla]

Make no sense for me, where should be session_write_close() "in condition too" ?
After session_regenerate_id(TRUE) it is unnecessary because there is another session_write_close() after condition. But it should be always before $backup = $_SESSION;
Giving session_write_close() before session_regenerate_id(TRUE) is not obviously good idea.

[dg]

After session_regenerate_id(TRUE) it is unnecessary because there is another session_write_close() after condition

Why must be another after condition? Why call it when session is not active?

[luhla]

Well, thats true, it might not, when seesion status is not active, nothing will be writen to session. I will fix it.

[dg]

Thanks!

[luhla]

Thanks for nothing, you did the solution. :-)