Always map NPF_SetPacketFilter() errors by setting the C bit. - #656
Merged
Conversation
guyharris
force-pushed
the
fix-hw-filter-return
branch
from
January 10, 2023 06:12
3826f7f to
db6576e
Compare
Contributor
Author
|
I haven't compiled this, as I don't have a development environment, but most of the change is adding a big explanatory comment; the other changes are adding a new label and changing a goto to go to the new label. (@bonsaiviking: see also my emails of 2022-11-05 and 2022-11-06, subject "Handling of NT status values for OID get/set changes for OID_GEN_CURRENT_PACKET_FILTER between 1.60 and 1.71".) |
This might fix issue nmap#628. See the long comment added by this commit for details. (That mapping might just be working around another problem which, if it could be fixed, would mean we would no longer need to set the C bit.)
guyharris
force-pushed
the
fix-hw-filter-return
branch
from
January 10, 2023 08:32
db6576e to
0a87924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might fix issue #628. See the long comment added by this commit for details. (That mapping might just be working around another problem which, if it could be fixed, would mean we would no longer need to set the C bit.)