Skip to content

Windows ansible updates - #3211

Merged
StefanStojanovic merged 4 commits into
nodejs:mainfrom
JaneaSystems:mefi-windows-update
Mar 8, 2023
Merged

Windows ansible updates#3211
StefanStojanovic merged 4 commits into
nodejs:mainfrom
JaneaSystems:mefi-windows-update

Conversation

@StefanStojanovic

@StefanStojanovic StefanStojanovic commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

This PR contains a few changes for Windows machines in the CI:

  • We've noticed there were problems running ansible against RackSpace Windows test machines. @joaocgreis investigated and fixed that. He also updated the manual steps guide so others do not run into this same issue.
  • This PR also adds Windows 11 ARM64 machines to the inventory. This is a follow on PR for https://github.com/nodejs-private/secrets/pull/246 which already updated the secrets repo.
  • Non-server Windows versions eg. Windows 10 and 11, are showing a finish setting up device screen after rebooting occasionally, and this was leaving newly added Windows 11 ARM64 machines offline after running windows-update-reboot. That behavior is disabled now, and this is already deployed to the machines that needed the fix.
  • .NET SDK is now installed in addition to the Native Desktop Workload. This is a prerequisite for landing a migration to WiX4 PR msi: migrate to WiX4 node#45943. This is already deployed to the Rackspace Win2012r2 VS2019 machines used for compilation and the PR was compiled successfully after that https://ci.nodejs.org/job/node-test-commit-windows-fanned/53615/. The plan is to update other VS2019 machines in CI after this PR lands.

joaocgreis and others added 4 commits March 8, 2023 13:01
@joaocgreis @StefanStojanovic
ansible,doc: update Windows manual steps
729c4b2 
PR-URL: nodejs#3211
Reviewed-By: Richard Lau <rlau@redhat.com>
@StefanStojanovic
ansible: add .NET SDK on Windows
a7aa3c6 
This is required to migrate from WiX3 to WiX4 for building the Node msi.

Refs: nodejs/node#45943
PR-URL: nodejs#3211
Reviewed-By: Richard Lau <rlau@redhat.com>
@StefanStojanovic
ansible: prevent autologin block on reboot windows
6b02368 
Windows 10 and 11 machines occasionally show finish setting up device
screen thus preventing Jenkins from starting after reboot. These changes
disable that behavior.

Refs: nodejs#3046
PR-URL: nodejs#3211
Reviewed-By: Richard Lau <rlau@redhat.com>
@StefanStojanovic
ansible: add win11 arm64 machines to inventory
1566a93 
Refs: nodejs-private/secrets#246
PR-URL: nodejs#3211
Reviewed-By: Richard Lau <rlau@redhat.com>
@StefanStojanovic
StefanStojanovic merged commit faf52ba into nodejs:main Mar 8, 2023
StefanStojanovic pushed a commit that referenced this pull request Mar 8, 2023
@joaocgreis @StefanStojanovic
ansible,doc: update Windows manual steps
bd0960f 
PR-URL: #3211
Reviewed-By: Richard Lau <rlau@redhat.com>
StefanStojanovic added a commit that referenced this pull request Mar 8, 2023
@StefanStojanovic
ansible: add .NET SDK on Windows
7731bb7 
This is required to migrate from WiX3 to WiX4 for building the Node msi.

Refs: nodejs/node#45943
PR-URL: #3211
Reviewed-By: Richard Lau <rlau@redhat.com>
StefanStojanovic added a commit that referenced this pull request Mar 8, 2023
@StefanStojanovic
ansible: prevent autologin block on reboot windows
9b882df 
Windows 10 and 11 machines occasionally show finish setting up device
screen thus preventing Jenkins from starting after reboot. These changes
disable that behavior.

Refs: #3046
PR-URL: #3211
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

ansible platform:windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StefanStojanovic @richardlau @joaocgreis