Fix s/fn performance issues in Clojure - #430
Merged
Merged
Conversation
w01fe
reviewed
Nov 5, 2021
Contributor
Author
|
There was an oversight in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to implement
s/defprotocol, I needed the following invariant to hold in Clojure to access __methodImplCache:The fix I chose was to use
^{:schema schema} (fn ...)instead of(with-meta (fn ...) {:schema schema}). I believe this also fixed all the documented performance caveats fors/fnin Clojure as it means wrappers are eliminated.The perf characteristics for CLJS seem unchanged (still uses the wrapper). I worked around CLJS-968 by placing the function evaluation in non-tail position. I decided working around this issue was better than using
macros/if-cljs(which I treat as a last resort).I also moved a test, please ignore whitespace changes when reviewing.