Skip to content

Fix DimensionTable virtualized jankiness - #8320

Merged
lovincyrus merged 2 commits into
mainfrom
cyrus/dimension-display-virtz-table-jankiness
Nov 18, 2025
Merged

Fix DimensionTable virtualized jankiness#8320
lovincyrus merged 2 commits into
mainfrom
cyrus/dimension-display-virtz-table-jankiness

Conversation

@lovincyrus

@lovincyrus lovincyrus commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

This PR tweaks the row and col overscan values to address the flick-scrolling blank rows. Fixes https://linear.app/rilldata/issue/APP-282/issue-with-loading-leaderboard-table-rows

before.mp4
after.mp4

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Nov 13, 2025
@lovincyrus
lovincyrus requested a review from ericokuma November 13, 2025 10:05
@lovincyrus
lovincyrus marked this pull request as ready for review November 13, 2025 13:13
@ericokuma

Copy link
Copy Markdown
Contributor

@lovincyrus

Copy link
Copy Markdown
Contributor Author

@lovincyrus

Copy link
Copy Markdown
Contributor Author

This is now waiting for Product UXQA @ericokuma

Copy link
Copy Markdown
Contributor

@lovincyrus

lovincyrus commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

https://www.loom.com/share/7e6391fcd0ad49dda77a0e2074fa6c99

I noticed that the recorded video is using ui.rilldata.com. Did you QA this branch locally?

See the before & after videos in the PR description.

@lovincyrus
lovincyrus force-pushed the cyrus/dimension-display-virtz-table-jankiness branch from bba78b6 to 4113666 Compare November 18, 2025 12:10
@lovincyrus

Copy link
Copy Markdown
Contributor Author

Since we got an eng review +1, I'm merging this. If there's any input, we can fast follow.

@lovincyrus
lovincyrus merged commit df5c854 into main Nov 18, 2025
9 of 10 checks passed
@lovincyrus
lovincyrus deleted the cyrus/dimension-display-virtz-table-jankiness branch November 18, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants