Skip to content

fix: canvas sub/unsub race condition - #9632

Merged
AdityaHegde merged 1 commit into
mainfrom
fix/canvas-sub-unsub-race
Jun 30, 2026
Merged

fix: canvas sub/unsub race condition#9632
AdityaHegde merged 1 commit into
mainfrom
fix/canvas-sub-unsub-race

Conversation

@AdityaHegde

@AdityaHegde AdityaHegde commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

In #9606 we fixed canvas sub/unsub issues when moving from a canvas route to non-canvas route or a different canvas route. But going from canvas to same canvas route, (the preview button in rill dev) still has the old issue of components being unmounted.

Improving the checks to have a count of subsriptions per canvas. This way mounting and unmounting the same canvas doesnt leave the stores in unsubbed state.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde
AdityaHegde requested a review from djbarnwal June 30, 2026 15:43
@AdityaHegde
AdityaHegde marked this pull request as ready for review June 30, 2026 15:43
@AdityaHegde
AdityaHegde merged commit 1743569 into main Jun 30, 2026
16 checks passed
@AdityaHegde
AdityaHegde deleted the fix/canvas-sub-unsub-race branch June 30, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants