Skip to content

Full diff preview when previewing changes - #9634

Merged
k-anshul merged 19 commits into
mainfrom
anshul/view-diff-dialog
Jul 6, 2026
Merged

Full diff preview when previewing changes#9634
k-anshul merged 19 commits into
mainfrom
anshul/view-diff-dialog

Conversation

@k-anshul

@k-anshul k-anshul commented Jul 1, 2026

Copy link
Copy Markdown
Member

closes https://linear.app/rilldata/issue/ENG-1120/option-to-view-file-changes-before-committing-in-cloud-editing

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Jul 1, 2026
@k-anshul

k-anshul commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed42e28929

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime/pkg/gitutil/sync.go Outdated
@k-anshul
k-anshul marked this pull request as ready for review July 1, 2026 10:27

@AdityaHegde AdityaHegde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Lets move the new files to changes folder under project.
  2. New components should be moved to svelte5

@AdityaHegde AdityaHegde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This was probably in the original component as well, but it doesnt look good in dark mode. Maybe out of scope of this PR.
  2. We should add the file icon from left nav beside the files. I dont see a way to configure it in the diff view so lets add it to the sidebar. We can hide the icon in diff view.
Image

Comment thread web-common/src/features/project/ChangedFilesDialog.svelte Outdated
Comment thread web-common/src/features/project/ChangedFilesDialog.svelte Outdated
Comment thread web-common/src/features/project/ChangedFilesDialog.svelte Outdated
@nishantmonu51 nishantmonu51 added Type:Feature New feature request Size:XL Very large change: 2,000+ lines labels Jul 2, 2026
@k-anshul
k-anshul merged commit 407c580 into main Jul 6, 2026
18 of 19 checks passed
@k-anshul
k-anshul deleted the anshul/view-diff-dialog branch July 6, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size:XL Very large change: 2,000+ lines Type:Feature New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants