Skip to content

fix: use branch-aware URL for Project Graphs link in DAG overlay - #9655

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-project-graphs-link-branch-url
Jul 7, 2026
Merged

fix: use branch-aware URL for Project Graphs link in DAG overlay#9655
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-project-graphs-link-branch-url

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator
  • The "Project Graphs" link in the resource graph quick-view overlay (ResourceGraphOverlay.svelte) used a hardcoded absolute /graph path.
  • In Rill Cloud editing, the graph route is prefixed with /{org}/{project}/@{branch}/-/edit, so the absolute path 404s and ignores the branch context.
  • Routed the href through withEditorPrefix() — the same helper the graph's own summary-node navigation already uses (SummaryNode.svelte). It resolves correctly in web-admin and is a no-op ("") in web-local.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Developed in collaboration with Claude Code

The "Project Graphs" link in the resource graph quick-view overlay used a hardcoded absolute /graph path, which 404s in Rill Cloud editing where the graph route is prefixed with /{org}/{project}/@{branch}/-/edit. Route the href through withEditorPrefix so it resolves correctly in both web-admin and web-local.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the “Project Graphs” link in the Resource Graph quick-view overlay so it respects the Cloud editor route prefix (org/project/branch edit context) instead of using a hardcoded absolute /graph path.

Changes:

  • Adds editor-route prefixing to the overlay’s graph link so it resolves correctly in Cloud edit routes.
  • Reuses the shared editor-routing mechanism used elsewhere for graph navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nishantmonu51
nishantmonu51 merged commit 6de09c4 into main Jul 7, 2026
19 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/fix-project-graphs-link-branch-url branch July 7, 2026 05:35
@nishantmonu51 nishantmonu51 added Type:Bug Something isn't working Size:S Small change: under 100 lines labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size:S Small change: under 100 lines Type:Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants