fix: use branch-aware URL for Project Graphs link in DAG overlay - #9655
Merged
Conversation
The "Project Graphs" link in the resource graph quick-view overlay used a hardcoded absolute /graph path, which 404s in Rill Cloud editing where the graph route is prefixed with /{org}/{project}/@{branch}/-/edit. Route the href through withEditorPrefix so it resolves correctly in both web-admin and web-local.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the “Project Graphs” link in the Resource Graph quick-view overlay so it respects the Cloud editor route prefix (org/project/branch edit context) instead of using a hardcoded absolute /graph path.
Changes:
- Adds editor-route prefixing to the overlay’s graph link so it resolves correctly in Cloud edit routes.
- Reuses the shared editor-routing mechanism used elsewhere for graph navigation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdityaHegde
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceGraphOverlay.svelte) used a hardcoded absolute/graphpath./{org}/{project}/@{branch}/-/edit, so the absolute path 404s and ignores the branch context.withEditorPrefix()— the same helper the graph's own summary-node navigation already uses (SummaryNode.svelte). It resolves correctly in web-admin and is a no-op ("") in web-local.Checklist:
Developed in collaboration with Claude Code