fix: exports failing intermittently due to tmp directory errors - #9658
Merged
Conversation
himadrisingh
approved these changes
Jul 7, 2026
pjain1
reviewed
Jul 7, 2026
|
|
||
| // Direct DuckDB's temp directory to our controlled tmpDir. | ||
| // By default, in-memory DuckDB creates ".tmp" in the current working directory, which may not be writable. | ||
| duckdbTmpDir, err := c.storage.RandomTempDir("duckdb-tmp") |
Member
There was a problem hiding this comment.
Can this be a sub directory inside tmpDir itself? Also if its a separate dir then lets defer os.RemoveAll(duckdbTmpDir) before defer duckdb.Close() so that first duckdb is closed first and then dir is removed.
Member
Author
There was a problem hiding this comment.
Can this be a sub directory inside tmpDir itself?
It can be but felt better to isolate from sqlite db file which can also generate its own journal files/tmp files.
Also if its a separate dir then lets defer os.RemoveAll(duckdbTmpDir) before defer duckdb.Close() so that first duckdb is closed first and then dir is removed.
Sure.
k-anshul
added a commit
that referenced
this pull request
Jul 7, 2026
* fix: exports failing intermittently due to tmp directory errors * review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: