Skip to content

fix: transient Metrics view not found error flash in canvas table/pivot components - #9674

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishantmonu51/fix-canvas-pivot-error-flash
Jul 13, 2026
Merged

fix: transient Metrics view not found error flash in canvas table/pivot components#9674
nishantmonu51 merged 1 commit into
mainfrom
nishantmonu51/fix-canvas-pivot-error-flash

Conversation

@nishantmonu51

@nishantmonu51 nishantmonu51 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator
  • On canvas page load, the table/pivot component briefly flashed a red Metrics view not found error before rendering: while the ListResources query was still in flight, validateTableSchema treated the momentarily-undefined metrics view spec as a hard error.
  • validateTableSchema now takes the { metricsView, isLoading } query result and reports a loading state instead of an error while the fetch is in flight, matching the existing guards in the KPI, chart, and leaderboard components.
  • CanvasPivotDisplay skips populating pivot state until loading completes, so column/time-dimension mapping is not computed from an undefined spec. While loading, the component falls through to the pivot's existing loading spinner; a genuine missing metrics view still shows the error.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator Author

@codex: review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: a42b2e0ef7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nishantmonu51
nishantmonu51 merged commit 70d1b3e into main Jul 13, 2026
16 checks passed
@nishantmonu51
nishantmonu51 deleted the nishantmonu51/fix-canvas-pivot-error-flash branch July 13, 2026 12:04
nishantmonu51 added a commit that referenced this pull request Jul 14, 2026
…ivot while metrics views load (#9674)

(cherry picked from commit 70d1b3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants