Prevent ClickHouse tenant database name collisions by keeping the resource ID from being truncated - #9683
Merged
Conversation
…ource ID from being truncated
| // Format: rill_<id>_<org>_<project> truncated to 63 characters. | ||
| // Note that we add the ID first to prevent it from being truncated (it adds 32 characters), which would be a security risk. | ||
| name := "rill" | ||
| name += "_" + nonAlphanumericRegexp.ReplaceAllString(resourceID, "") |
Collaborator
There was a problem hiding this comment.
I am assuming this change would be backwards compatible and existing projects will not be affected ?
Contributor
Author
There was a problem hiding this comment.
Yes, the name is persisted, so it will only affect new provisions going forward
Collaborator
|
@codex: review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
nishantmonu51
approved these changes
Jul 14, 2026
nishantmonu51
added
Type:Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.