Skip to content

fix: file list in revert confirmation dialog overlaps instead of scrolling - #9690

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-revert-dialog-file-list-scroll
Jul 15, 2026
Merged

fix: file list in revert confirmation dialog overlaps instead of scrolling#9690
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-revert-dialog-file-list-scroll

Conversation

@nishantmonu51

@nishantmonu51 nishantmonu51 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator
  • With many changed files, the file list in the revert confirmation dialog rendered as overlapping text instead of scrolling.
  • The list is a flex flex-col container with max-h-40 overflow-y-auto, but each li uses truncate (overflow: hidden), which drops the flex items' automatic minimum size to zero — so flexbox compressed the rows vertically rather than overflowing into the scrollbar.
  • Added shrink-0 to the list items so they keep their natural height and the list scrolls as intended.

Before this overlapping text -
Screenshot 2026-07-15 at 9 35 59 PM

After this, clear listing and scrollable list -
Screenshot 2026-07-15 at 9 34 36 PM

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51
nishantmonu51 merged commit 1feab36 into main Jul 15, 2026
19 of 20 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/fix-revert-dialog-file-list-scroll branch July 15, 2026 17:32
nishantmonu51 added a commit that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants