Tracking issue for Seek::{stream_len, stream_position} (feature `seek_convenience`)

[LukasKalbertodt]

View all comments

This is a tracking issue for Seek::{stream_len, stream_position}. Proposed and implemented in #58422.

Unresolved questions:

• Override stream_len for File? (is metadata syncing a problem? comment a, comment b)
• Final names:
  • Rename to len and position? (but that's a strange signature for len and position clashes with Cursor
  • ...

[meithecatte]

As the issue calls for a bikeshed... tell seems to be an established name for what is called stream_position here. I don't see an analogous alternative name for stream_length, though, and the two methods having similar names might be advantageous. Besides, stream_position is more descriptive.

[marmistrz]

From the API user perspective, stream_position should probably borrow immutably.

[LukasKalbertodt]

I opened a stabilization PR here: #70904

---

From the API user perspective, stream_position should probably borrow immutably.

@marmistrz Yes, that would be nice. But it's not possible as the method is just a small helper around seek. And seek requires &mut self.

[marmistrz]

Yes, therefore this should be implemented separately, on the low level, just as it's done in yanix:
https://github.com/bytecodealliance/wasmtime/blob/c4e90f729ca5e17a29a778ace7971aeda7c22391/crates/wasi-common/yanix/src/file.rs#L251-L258

[LukasKalbertodt]

@marmistrz Unfortunately, I don't quite understand what you are suggesting. And in particular: are you opposing stabilization of the features as they currently are?