Skip to content

Remove internal PathBuf::as_mut_vec - #126885

Merged
bors merged 4 commits into
rust-lang:masterfrom
tnuha:rm_internal_pathbuf_asmutvec
Jun 25, 2024
Merged

Remove internal PathBuf::as_mut_vec#126885
bors merged 4 commits into
rust-lang:masterfrom
tnuha:rm_internal_pathbuf_asmutvec

Conversation

@tnuha

@tnuha tnuha commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

closes #126333

@rustbot

rustbot commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024
@rustbot

rustbot commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@tnuha
tnuha force-pushed the rm_internal_pathbuf_asmutvec branch from 80dc4b6 to 0db5415 Compare June 24, 2024 02:02
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024
@tnuha

tnuha commented Jun 24, 2024

Copy link
Copy Markdown
Contributor Author

r? @workingjubilee

@rustbot rustbot assigned workingjubilee and unassigned cuviper Jun 24, 2024
workingjubilee
workingjubilee reviewed Jun 24, 2024
View reviewed changes

@workingjubilee workingjubilee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks overall good, though I do have a general nit. I will review the actual implementation more closely in a moment.

Comment thread library/std/src/ffi/os_str.rs Outdated
Comment thread library/std/src/path.rs Outdated
Comment thread library/std/src/sys/os_str/bytes.rs Outdated
Comment thread library/std/src/ffi/os_str.rs Outdated
workingjubilee
workingjubilee reviewed Jun 24, 2024
View reviewed changes

@workingjubilee workingjubilee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread library/std/src/sys_common/wtf8.rs
Comment thread library/std/src/sys/os_str/wtf8.rs
@tnuha
tnuha force-pushed the rm_internal_pathbuf_asmutvec branch from 0db5415 to 5d60720 Compare June 24, 2024 04:02
@tnuha

tnuha commented Jun 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Alright, this should be a better sign-off. In case this ends up being a good final PR, thank you again for your mentorship, and here's to future collaboration 😄 you rock, my friend!

@workingjubilee

workingjubilee commented Jun 25, 2024

Copy link
Copy Markdown
Member

Thank you!

One thing left: can you squash at least the last ~6 or so commits into one? They're mostly just fixups of the same "add the actual alternate implementations" change.

@tnuha
tnuha force-pushed the rm_internal_pathbuf_asmutvec branch from da8e157 to aa46a33 Compare June 25, 2024 13:36
@workingjubilee

workingjubilee commented Jun 25, 2024

Copy link
Copy Markdown
Member

Woo! Let's see how this goes.

@bors r+

@bors

bors commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit aa46a33 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2024
@workingjubilee workingjubilee mentioned this pull request Jun 25, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 25, 2024
Merged
@bors
bors merged commit 9d7e146 into rust-lang:master Jun 25, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 25, 2024
@tnuha
tnuha deleted the rm_internal_pathbuf_asmutvec branch June 26, 2024 00:31
@tnuha
tnuha restored the rm_internal_pathbuf_asmutvec branch June 26, 2024 00:35
This was referenced Jun 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@workingjubilee workingjubilee

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

Remove internal PathBuf::as_mut_vec

6 participants

@tnuha @rustbot @workingjubilee @bors @yhx-12243 @cuviper