Skip to content

rustdoc: Eliminate edition sensitivity around RPIT lifetime capturing - #157213

Draft
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:rustdoc-opaque-edition-insensitive
Draft

rustdoc: Eliminate edition sensitivity around RPIT lifetime capturing#157213
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:rustdoc-opaque-edition-insensitive

Conversation

@fmease

@fmease fmease commented May 31, 2026

Copy link
Copy Markdown
Member

Fixes #135453.

TODO:

  • proper PR description
  • perf run
  • avoid synth'ing redundant use-bounds if feasible wrt. maintainability & perf
  • figure out how to deal with APITs (I'm probably "just" gonna go with use<…, /*all in-scope APITs*/>)
  • write tests
  • document this behavior in the rustdoc book
  • issue an FCP-merge

@fmease fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label May 31, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 31, 2026
@fmease fmease added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label May 31, 2026
@fmease

fmease commented May 31, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 31, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 31, 2026
…<try>

rustdoc: Eliminate edition sensitivity around RPIT lifetime capturing
@rust-bors

rust-bors Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 22299d7 (22299d71997d42c10d254f758953ef37d057b7b5, parent: 1ce45a011a3fe99ab08643d8eb7229bfc3b40bda)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (22299d7): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 6.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.4% [6.4%, 6.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [2.1%, 5.3%] 8
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.3%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 0.7%] 19
Regressions ❌
(secondary)
0.3% [0.0%, 0.4%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.1%, 0.7%] 19

Bootstrap: 513.507s -> 509.419s (-0.80%)
Artifact size: 400.69 MiB -> 400.74 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc: Consider eliminating edition sensitivity around RPIT capturing

3 participants