Skip to content

Make let-else respect macro_rules expr metavariable grouping - #158515

Open
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:let-else-detect-invisible-delimiter
Open

Make let-else respect macro_rules expr metavariable grouping#158515
bb1yd wants to merge 1 commit into
rust-lang:mainfrom
bb1yd:let-else-detect-invisible-delimiter

Conversation

@bb1yd

@bb1yd bb1yd commented Jun 28, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #147899

@rustbot

rustbot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 28, 2026
@rustbot

rustbot commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@bb1yd bb1yd changed the title make let-else respect macro_rules expr metavariable grouping Make let-else respect macro_rules expr metavariable grouping Jun 28, 2026
@bb1yd
bb1yd marked this pull request as draft June 28, 2026 08:00
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2026
@bb1yd
bb1yd force-pushed the let-else-detect-invisible-delimiter branch from 15b1465 to 5e53d92 Compare June 28, 2026 12:33
@bb1yd
bb1yd marked this pull request as ready for review June 28, 2026 13:25
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2026
@bb1yd

bb1yd commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@jackh726 Friendly ping, any feedback? :)

@jackh726

jackh726 commented Aug 7, 2026

Copy link
Copy Markdown
Member

Nominating for t-lang. This is a bug fix, but accepts new programs. Unsure if an FCP here is needed.

@jackh726 jackh726 added the I-lang-nominated Nominated for discussion during a lang team meeting. label Aug 7, 2026
@traviscross traviscross added P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team labels Aug 12, 2026
@traviscross

traviscross commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@rfcbot fcp merge lang

@rust-rfcbot

rust-rfcbot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 12, 2026
@joshtriplett

joshtriplett commented Aug 12, 2026

Copy link
Copy Markdown
Member

@rfcbot reviewed

@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Aug 12, 2026
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 12, 2026
@rust-rfcbot

rust-rfcbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Aug 12, 2026
@scottmcm

scottmcm commented Aug 12, 2026

Copy link
Copy Markdown
Member

This seems like it was obviously supposed to work this way, but under the "it'd be breaking to revert this" probably best to FCP it since it's a one-way thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726 jackh726

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

let-else does not respect macro_rules expr metavariable grouping

7 participants

@bb1yd @rustbot @jackh726 @traviscross @rust-rfcbot @joshtriplett @scottmcm