Skip to content

rustc_target: couple AArch64 LLVM and cfg pauthtest ABIs - #161229

Open
jchlanda wants to merge 2 commits into
rust-lang:mainfrom
jchlanda:jakub/pauth_consistency
Open

rustc_target: couple AArch64 LLVM and cfg pauthtest ABIs#161229
jchlanda wants to merge 2 commits into
rust-lang:mainfrom
jchlanda:jakub/pauth_consistency

Conversation

@jchlanda

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 17, 2026
@jchlanda
jchlanda marked this pull request as ready for review August 17, 2026 12:26
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Target consistency checks are being changed

cc @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@jchlanda

Copy link
Copy Markdown
Contributor Author

r? @RalfJung

@rustbot rustbot assigned RalfJung and unassigned petrochenkov Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung

Copy link
Copy Markdown
Member

Thanks. :-)

@bors r+ rollup

@RalfJung

Copy link
Copy Markdown
Member

Actually while we are at it, can you also fix the doc comment for the new LlvmAbi variant? Currently it is very non-descriptive. This value is specific for aarch64, right?

@bors r-

@rust-bors

rust-bors Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 558f22f has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2026
@jchlanda

Copy link
Copy Markdown
Contributor Author

Actually while we are at it, can you also fix the doc comment for the new LlvmAbi variant?

Sure, on it.

Currently it is very non-descriptive. This value is specific for aarch64, right?

Yes, it is.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2026
@rust-bors

rust-bors Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

Comment thread compiler/rustc_target/src/spec/mod.rs Outdated
Comment on lines +2127 to +2128
// AArch64 (Linux, ELF) pointer authentication ABI for the
// `aarch64-unknown-linux-pauthtest` target.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just say "Aarch64" here, matching the other targets.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jchlanda
jchlanda force-pushed the jakub/pauth_consistency branch from bee65dd to 90366ec Compare August 17, 2026 14:58
@RalfJung

Copy link
Copy Markdown
Member

Thanks. :-)

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 90366ec has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 17, 2026
…r=RalfJung

rustc_target: couple AArch64 LLVM and cfg pauthtest ABIs
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 17, 2026
…r=RalfJung

rustc_target: couple AArch64 LLVM and cfg pauthtest ABIs
rust-bors Bot pushed a commit that referenced this pull request Aug 17, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #161221 (`rust-analyzer` subtree update)
 - #161232 (Subtree sync for rustc_codegen_cranelift)
 - #160058 (atomic volatile: add intrinsics)
 - #161206 (Library lock file update)
 - #160905 (implement <IpAddr, SocketAddr>::unspecified_from())
 - #160986 (Move `LateParamRegion` to `rustc_type_ir`)
 - #161145 (Remove references to the obsolete `try-perf` branch)
 - #161197 (citool: update rust crates)
 - #161225 (Add regression test for lint panic on nested generic with default type param)
 - #161229 (rustc_target: couple AArch64 LLVM and cfg pauthtest ABIs)
 - #161230 (rename `#[rustc_dump_predicates]` to `#[rustc_dump_clauses]`)
 - #161237 (Remove jdno from infra-ci rotation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants