Skip to content

Reserve capacity for 3% anon nodes - #161254

Open
Zoxc wants to merge 1 commit into
rust-lang:mainfrom
Zoxc:anon-node-reserve
Open

Reserve capacity for 3% anon nodes#161254
Zoxc wants to merge 1 commit into
rust-lang:mainfrom
Zoxc:anon-node-reserve

Conversation

@Zoxc

@Zoxc Zoxc commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This reserves capacity for 3% anon nodes instead of 100%. For the benchmark suite the mean is ~1.6% and max ~5.8%, so I picked a middle ground.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 17, 2026
@Zoxc

Zoxc commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 17, 2026
Reserve capacity for 3% anon nodes
@Zoxc

Zoxc commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Mostly cuts down on committed memory locally:

BenchmarkBeforeAfterBeforeAfterBeforeAfter
TimeTime%Physical MemoryPhysical Memory%Committed MemoryCommitted Memory%
🟣 clap:check:unchanged0.3162s0.3130s -1.00%90.68 MiB90.39 MiB -0.32%163.99 MiB157.86 MiB💚 -3.74%
🟣 hyper:check:unchanged0.1313s0.1314s 0.10%56.85 MiB56.80 MiB -0.09%121.74 MiB120.23 MiB💚 -1.23%
🟣 regex:check:unchanged0.2275s0.2278s 0.11%76.87 MiB76.66 MiB -0.27%143.66 MiB137.63 MiB💚 -4.19%
🟣 syn:check:unchanged0.4812s0.4833s 0.43%111.32 MiB110.91 MiB -0.37%184.00 MiB171.91 MiB💚 -6.57%
Total1.1563s1.1556s -0.06%335.71 MiB334.75 MiB -0.29%613.38 MiB587.64 MiB💚 -4.20%
Summary1.0000s0.9991s -0.09%1 byte1.00 bytes -0.26%1 byte0.96 bytes💚 -3.93%

@rust-bors

rust-bors Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 07c4617 (07c46175c09f1f6c0cfa270871a3c03c3aadd621)
Base parent: 6d656b1 (6d656b1efca82491a110b476ac9bbe712628ccb6)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (07c4617): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.7%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [1.7%, 2.3%] 2
Regressions ❌
(secondary)
3.1% [0.8%, 6.1%] 8
Improvements ✅
(primary)
-1.2% [-2.5%, -0.4%] 11
Improvements ✅
(secondary)
-4.8% [-6.6%, -2.7%] 5
All ❌✅ (primary) -0.7% [-2.5%, 2.3%] 13

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 468.493s -> 457.557s (-2.33%)
Artifact size: 398.93 MiB -> 398.90 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2026
@Zoxc
Zoxc marked this pull request as ready for review August 17, 2026 20:50
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, incremental, query-system
  • compiler, incremental, query-system expanded to 75 candidates
  • Random selection from 16 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants