Skip to content

Don't rely on std traits not being const in tests - #161346

Open
Randl wants to merge 1 commit into
rust-lang:mainfrom
Randl:non-const-tests
Open

Don't rely on std traits not being const in tests#161346
Randl wants to merge 1 commit into
rust-lang:mainfrom
Randl:non-const-tests

Conversation

@Randl

@Randl Randl commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Many of these were dealt with in #155616
There are some remaining ones
r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2026
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

oli-obk
oli-obk reviewed Aug 19, 2026
View reviewed changes
Comment thread tests/ui/consts/const-fn-error.rs Outdated
oli-obk
oli-obk reviewed Aug 19, 2026
View reviewed changes
Comment thread tests/ui/statics/check-values-constraints.rs Outdated
@oli-obk

oli-obk commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c67ff2a has been approved by oli-obk

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: To keep an eye on

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 19, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161346 - Randl:non-const-tests, r=oli-obk
54e88f4 
Don't rely on std traits not being const in tests

Many of these were dealt with in rust-lang#155616
There are some remaining ones
r? @oli-obk
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Randl @rustbot @oli-obk