Use rustdoc.css for error index - #86663
Conversation
|
Some changes occurred in HTML/CSS themes. Some changes occurred in HTML/CSS/JS. |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Note that |
This comment has been minimized.
This comment has been minimized.
928fd37 to
d443416
Compare
|
This looks good to me, thanks for this fix! I'd feel better though if the @rust-lang/infra team took a look to this PR to ensure something wasn't overlooked. |
GuillaumeGomez
added
T-infra
|
@GuillaumeGomez I don't understand why you pinged the infra team. They don't own the index page AFAIK, I'm not sure who does. @ehuss you meant doc.rust-lang.org, right? @fee1-dead @GuillaumeGomez can one of you follow up on that? You can build all the docs locally with |
|
Last time I proposed to change the style on the error index page, it was rejected. (I think we discussed about it with @pietroalbini but don't remember...) I already checked it locally and it works so if there is no other thing to check, it can be r+ed. |
The link is to https://github.com/rust-lang/rust/blob/master/src/bootstrap/doc.rs, where the usage of |
@GuillaumeGomez do you recall when or where? I don't remember anything about the index page. |
|
I don't remember at all and can't find the PR. Maybe I just dreamed all this... |
|
@bors r=GuillaumeGomez This is easy enough to revert if necessary and it seems worthwhile to not have to keep things in sync. |
|
📌 Commit 5072a47 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
…ark-Simulacrum Don't add rustdoc's CSS to other doc pages This was originally added so those doc pages could use the same font files, but it turns out to be fragile. And those doc pages are just stubs that link to other pages, so they don't need fancy fonts. Before:  After:  Demo of all affected pages: https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/complement-design-faq.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/complement-lang-faq.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/complement-project-faq.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/grammar.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-crates.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-error-handling.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-ffi.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-macros.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-ownership.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-plugins.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-pointers.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-strings.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-tasks.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-testing.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/guide-unsafe.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/index.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/intro.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/not_found.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/reference.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/rustdoc.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/rust.html https://rustdoc.crud.net/jsha/aux-pages-no-rustdoc-css/tutorial.html Prior art: rust-lang#86663
9 participants
Closes #86512.