Skip to content

hostname: fix -d flag - #8657

Merged
sylvestre merged 2 commits into
uutils:mainfrom
bakanovskii:hostname-domain-fix
Oct 16, 2025
Merged

hostname: fix -d flag#8657
sylvestre merged 2 commits into
uutils:mainfrom
bakanovskii:hostname-domain-fix

Conversation

@bakanovskii

@bakanovskii bakanovskii commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Fixes #8656

@AnarchistHoneybun

Copy link
Copy Markdown
Contributor

you could change the text to say "Fixes ..." or "Resolves ..." to automatically link the pr to the issue

@sylvestre

Copy link
Copy Markdown
Contributor

could you please add a test to make sure we don't regress ? thanks

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@bakanovskii

Copy link
Copy Markdown
Contributor Author

could you please add a test to make sure we don't regress ? thanks

sure! I also found https://github.com/uutils/hostname/tree/main this repo which seems to be more complete
Is this a stage repo (WIP)? Should I contribute further to hostname binary?

@bakanovskii

Copy link
Copy Markdown
Contributor Author

@sylvestre, hello! Could you please review again?

@sylvestre
sylvestre merged commit 517b5fb into uutils:main Oct 16, 2025
95 checks passed
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Oct 25, 2025
* hostname: fix -d flag

* tests/hostname: test -d when no domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hostname: different behavior with -d flag

3 participants