Use JSON for internal platform config, to avoid TOML issues - #220
Merged
Conversation
Contributor
Author
|
Now this is what happens when I run the commands from that bug: |
dherman
requested changes
Dec 16, 2018
dherman
left a comment
Collaborator
There was a problem hiding this comment.
A couple suggestions.
Another thought that occurs to me is that TOML is optimized for human-readability, which is where some of these complexities come from. Maybe for internal files like platform.toml we'd be better off with JSON. IOW, the policy would be: TOML for human-maintained files (like the hooks configuration), and JSON for files representing internal state. Just a thought; we could also decide later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219.