Change node version for action to node20 - #866
Merged
dmitry-shibanov merged 8 commits intoOct 23, 2023
Merged
Conversation
marko-zivic-93
approved these changes
Oct 9, 2023
IvanZosimov
approved these changes
Oct 9, 2023
dusan-trickovic
approved these changes
Oct 9, 2023
nikolai-laevskii
approved these changes
Oct 10, 2023
MaksimZhukov
approved these changes
Oct 10, 2023
dsame
reviewed
Oct 17, 2023
| ); | ||
| } else { | ||
| core.info(err.message); | ||
| core.info((err as Error).message); |
Contributor
There was a problem hiding this comment.
If the compiler does not detect the 'Error' class, shouldn't we dynamically check it, either with a type guard or as simple as (err.message && message || something)?
Contributor
Author
There was a problem hiding this comment.
I think it is unnecessary because if it was not an error initially, the code related to core.info will fail because it accepts only strings. It is unexpected behaviour that string is thrown instead of Error.
MaksimZhukov
approved these changes
Oct 23, 2023
Closed
2 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we switch node version of the action to node20.
Related issue:
#850
Check list: