Argument Clinic: char convertor should use default values of type bytes

[taleinat]

BPO	20304
Nosy	@taleinat, @larryhastings, @serhiy-storchaka
PRs	bpo-20180: complete AC conversion of Objects/stringlib/transmogrify.h #8039

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-12.13:06:22.204>
created_at = <Date 2014-01-19.15:51:05.603>
labels = ['type-bug', '3.8', 'expert-argument-clinic', 'build']
title = 'Argument Clinic: char convertor should use default values of type bytes'
updated_at = <Date 2018-10-12.13:06:22.195>
user = 'https://github.com/taleinat'

bugs.python.org fields:

activity = <Date 2018-10-12.13:06:22.195>
actor = 'taleinat'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-12.13:06:22.204>
closer = 'taleinat'
components = ['Build', 'Demos and Tools', 'Argument Clinic']
creation = <Date 2014-01-19.15:51:05.603>
creator = 'taleinat'
dependencies = []
files = []
hgrepos = []
issue_num = 20304
keywords = ['patch']
message_count = 4.0
messages = ['208481', '208483', '320831', '327584']
nosy_count = 3.0
nosy_names = ['taleinat', 'larry', 'serhiy.storchaka']
pr_nums = ['8039']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20304'
versions = ['Python 3.8']

[taleinat]

For example, in Object/stringlib/transmogrify.h, the methods ljust and rjust have an argument named fillchar of type char. It's Python default value should be b' ', but the only way I've found to do that is by setting py_default = b' '.

[taleinat]

Additionally, the char converter doesn't create valid c defaults. For example, I got " " instead of ' ' for fillchar, which has type char, so I had to manually set c_default = "' '".

[taleinat]

See PR #52287, which fixes this in order to AC convert Objects/stringlib/transmogrify.h.

[taleinat]

This was fixed in PR #52287.