SQL Comments

[gramian]

Dear Developers,

The comment tokens for SQL comments are not described in the documentation.

Checking the source I found that only the syntax /* ... */ is supported (?) for either single-line and multi-line comments is supported.

I would really appreciate if the classic SQL syntax -- (double dash) would be supported for single-line comments, so I would like to ask if such extension is agreeable with you and: https://stackoverflow.com/a/59706280 would be sufficient code-wise?

Best

[gramian]

FYI: javacc has an example for a single line SQL comment:

SPECIAL_TOKEN:
{
   <LINE_COMMENT: "--"(~["\r","\n"])*>
}

[lvca]

This is something we could do quite easily. Working on it.

[lvca]

Transfering the issue to the main ArcadeDB source repository.

[gramian]

Great! Thank you. To me, that makes it feel even more like SQL.

Experimenting, I added the code block above to the grammar file, compiled, tested and packaged it and it seemed to work directly.

[lvca]

Same, but this test case won't pass

    checkRightSyntax("-- aaa bbb ccc\nselect from Comments");

[lvca]

Seems that once in a -- line comment, everything is wrongly parsed.

[gramian]

So the \n (escaped newline) is not found?

[lvca]

This did the trick:

  <"--" (~["\n"])*> : DEFAULT

Waiting for the tests to pass.

[gramian]

I assumed the \r was in there because of Windows line ends. Unfortunately, I do not have a Windows box for testing this.

[lvca]

Unfortunately some tests won't pass, the ones with the MATCH because we have --> in the syntax:

  @Test
  public void testMultipleMatchesArrow() {
    String query = "MATCH {type: 'V', as: foo}-->{type: 'V', as: bar}, ";
    query += " {type: 'V', as: foo}-->{type: 'V', as: bar},";
    query += " {type: 'V', as: foo}-->{type: 'V', as: bar} RETURN foo";
    checkRightSyntax(query);
  }

Anybody is familiar with JavaCC?

[gramian]

Would this help? So, here a dummy --> could help(?).