Skip to content

[Stack Switching] Fix ctor-eval handling of unhandled resumes#8556

Merged
kripken merged 2 commits into
WebAssembly:mainfrom
kripken:ctor.eval.resume.unh
Mar 31, 2026
Merged

[Stack Switching] Fix ctor-eval handling of unhandled resumes#8556
kripken merged 2 commits into
WebAssembly:mainfrom
kripken:ctor.eval.resume.unh

Conversation

@kripken

@kripken kripken commented Mar 31, 2026

Copy link
Copy Markdown
Member

The logic for this was in the wrong place. It should be where we handle a
non-constant operation, as it is something that stops us and prevents
precomputing. (Before, it was down by a branch, but a branch is a very
special case in which we can ignore the branch, because we know it
goes to the toplevel block, skipping what is after it.)

Fixes #8553

@kripken kripken requested a review from tlively March 31, 2026 18:05
@kripken kripken requested a review from a team as a code owner March 31, 2026 18:05
@kripken kripken merged commit 8242d19 into WebAssembly:main Mar 31, 2026
15 checks passed
@kripken kripken deleted the ctor.eval.resume.unh branch March 31, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm-ctor-eval bug with suspend

2 participants