Skip to content

Size reduction by 14 B#19

Merged
ai merged 1 commit into
ai:masterfrom
gwer:reduce_size
Oct 30, 2018
Merged

Size reduction by 14 B#19
ai merged 1 commit into
ai:masterfrom
gwer:reduce_size

Conversation

@gwer

@gwer gwer commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

Remove bitshifting hack.
Remove variables reuse.
Use [].slice for Object.prototype properties collision fix.

@ai

ai commented Oct 30, 2018

Copy link
Copy Markdown
Owner

Can you run ./test/benchmark on Node 11 before and after this fix?

I tried this way before, but on old Node.js found big reducing in performance.

@gwer

gwer commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Are you sure ./test/benchmark should exist?

@ai

ai commented Oct 30, 2018

Copy link
Copy Markdown
Owner

Oops, it is a wrong nano* project :D

I thought I was in Nano ID

@ai
ai merged commit cd2f9c1 into ai:master Oct 30, 2018
@ai

ai commented Oct 30, 2018

Copy link
Copy Markdown
Owner

Thanks. Released in 1.0.8.

@StreetStrider

Copy link
Copy Markdown

That was a beautiful in-place hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants