Skip to content

branch-4.1: [fix](filecache) add async lru update machanism and fix partial hit in cache reader (pick #61083)#61812

Merged
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:task-branch-4-1-pick-pr-61083
Mar 28, 2026
Merged

branch-4.1: [fix](filecache) add async lru update machanism and fix partial hit in cache reader (pick #61083)#61812
yiguolei merged 3 commits into
apache:branch-4.1from
freemandealer:task-branch-4-1-pick-pr-61083

Conversation

@freemandealer

Copy link
Copy Markdown
Member
  • CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead)
  • Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting
  • Established performance unit tests for cache lock

Signed-off-by: zhengyu zhangzhengyu@selectdb.com

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
(cherry picked from commit 5467a2f)
…n cache reader

- CachedRemoteFileReader::read_at_impl has incorrect initialization of subsequent traversal start point and count after direct partial hit (causes incorrect fallback / extra overhead)
- Proposed LRU ordering async update solution: Decoupled LRU update from query read operations, slightly reducing read lock latency and laying groundwork for subsequent lock splitting
- Established performance unit tests for cache lock

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
(cherry picked from commit cbe632c)
@freemandealer
freemandealer requested a review from yiguolei as a code owner March 27, 2026 08:47
@Thearas

Thearas commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

Copy link
Copy Markdown
Member Author

run buildall

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (21/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.87% (19559/36992)
Line Coverage 36.18% (182595/504696)
Region Coverage 32.50% (141123/434261)
Branch Coverage 33.73% (62007/183860)

@freemandealer

Copy link
Copy Markdown
Member Author

run external

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (21/21) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.79% (26355/36207)
Line Coverage 56.06% (281995/502995)
Region Coverage 53.71% (235371/438228)
Branch Coverage 55.41% (102174/184386)

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei closed this Mar 28, 2026
@yiguolei yiguolei reopened this Mar 28, 2026
@yiguolei
yiguolei merged commit 550bd2d into apache:branch-4.1 Mar 28, 2026
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants