branch-4.1: [fix](planner) align legacy literal compareLiteral with Nereids ComparableLiteral semantics (#63481)#63874
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
…ereids ComparableLiteral semantics (apache#63481) IPv4Literal/IPv6Literal.compareLiteral both used to return 0 unconditionally, making any two IP literals appear equal to LiteralExpr.equals(). The downstream effect: WHERE ip4 != '1.1.1.1' AND ip4 != '1.1.1.2' collapsed to just the first conjunct during Set<Expr> dedup inside the legacy planner's ScanNode.expressionToRanges / PartitionColumnFilter / HashDistributionPruner paths. Same shape for NOT BETWEEN and NOT IN. Multiple rows that should have been filtered out leaked through, and EXPLAIN only showed the first predicate. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
csun5285
force-pushed
the
pick-63481-to-4.1
branch
from
May 29, 2026 04:15
fbe6af0 to
1db7234
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
yiguolei
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from master #63481