branch-4.0:[fix](partition_prune) Avoid incorrect convert_tz partition pruning across DST transitions #63853#64827
Merged
Conversation
…cross DST transitions (apache#63853) ### What problem does this PR solve? Related PR: apache#40047 apache#64029 Problem Summary: Nereids currently treats `convert_tz()` as monotonic whenever both timezone arguments are constant. That assumption is not always correct. When a partition predicate contains `convert_tz(partition_col, from_tz, to_tz)`, partition pruning folds the partition range endpoints and infers a value range for the function. This is only valid if `convert_tz()` is monotonic on the current partition range. Across DST transitions, `convert_tz()` is not monotonic: - during fall-back, different input timestamps can map to the same local time - during spring-forward, a local-time gap can break the endpoint-based range inference As a result, FE may prune partitions that still contain matching rows. The reported case is `convert_tz(ts, 'UTC', 'Europe/Paris')` around the Europe/Paris DST fall-back boundary, where a valid partition is incorrectly removed. This PR fixes the issue by tightening the monotonicity check for `convert_tz()`: - keep the optimization for fixed-offset timezones - disable the monotonic shortcut when the source local-time range touches a DST transition window - disable the monotonic shortcut when the corresponding target instant range touches a DST transition This keeps normal partition pruning behavior for safe cases while avoiding wrong pruning around DST boundaries.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
morningman
approved these changes
Jun 25, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picked from #63853