branch-4.1: [improvement](catalog) narrow MaterializedIndex addTablet sync scope #64478#64859
Merged
Merged
Conversation
…64478) Move the synchronized modifier from the public addTablet / appendTablets methods onto appendTabletsInternal, the only block that actually mutates the per-index list and idToTablets map. The TabletInvertedIndex.addTablet(...) call in the non-restore path of addTablet does not need to share this lock — it has its own internal synchronization and operates on a separate object. Holding the per-index monitor across that call only serialized unrelated writers without guarding any shared state on this index. Readers see the new tablets via the same volatile publish in appendTabletsInternal as before, so the existing TOCTOU window between the per-index snapshot and TabletInvertedIndex (handled by the IllegalStateException catch in TabletStatMgr.updateTabletStat) is unchanged in both width and shape. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #63298 Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
run feut |
yiguolei
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64478