Skip to content

feat: Better Actor API typing#256

Merged
janbuchar merged 9 commits into
masterfrom
better-actor-api-typing
Aug 29, 2024
Merged

feat: Better Actor API typing#256
janbuchar merged 9 commits into
masterfrom
better-actor-api-typing

Conversation

@janbuchar

Copy link
Copy Markdown
Contributor

Methods such as Actor.add_webhook or Actor.start now use Pydantic models to ensure correctness and enable type checking and completions.

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 29, 2024
@janbuchar
janbuchar requested a review from vdusek August 29, 2024 10:41
@github-actions github-actions Bot added this to the 97th sprint - Tooling team milestone Aug 29, 2024
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Aug 29, 2024

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, just some details (not requesting)...

Comment thread src/apify/_models.py
Comment thread src/apify/_models.py
Comment thread src/apify/_actor.py Outdated
janbuchar and others added 2 commits August 29, 2024 14:24
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@janbuchar
janbuchar merged commit abb87e7 into master Aug 29, 2024
@janbuchar
janbuchar deleted the better-actor-api-typing branch August 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return well-typed objects for Actor methods that work with the apify client

2 participants