fix: Fix RQ usage in Scrapy scheduler#385
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
janbuchar
reviewed
Jan 29, 2025
| Raises: | ||
| ValueError: If username and password are not provided in the proxy URL. | ||
| """ | ||
| # Do not use proxy for robots.txt, as it causes 403 Forbidden. |
Contributor
There was a problem hiding this comment.
Like... universally, everywhere? I don't mind it, it just seems weird.
Contributor
Author
There was a problem hiding this comment.
Maybe it is a problem of Apify proxies, I don't know, but it results in the following:
[scrapy.downloadermiddlewares.robotstxt] ERROR Error downloading <GET https://console.apify.com/robots.txt>: Could not open CONNECT tunnel with proxy proxy.apify.com:8000 [{'status': 403, 'reason': b'Forbidden'}] ({"spider": "<TitleSpider 'title_spider' at 0x7f2bc3aee660>"})
Traceback (most recent call last):
File "/home/vdusek/Projects/apify-sdk-python/.venv/lib/python3.13/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
result = context.run(
cast(Failure, result).throwExceptionIntoGenerator, gen
)
File "/home/vdusek/Projects/apify-sdk-python/.venv/lib/python3.13/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
return g.throw(self.value.with_traceback(self.tb))
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vdusek/Projects/apify-sdk-python/.venv/lib/python3.13/site-packages/scrapy/core/downloader/middleware.py", line 68, in process_request
return (yield download_func(request, spider))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
scrapy.core.downloader.handlers.http11.TunnelError: Could not open CONNECT tunnel with proxy proxy.apify.com:8000 [{'status': 403, 'reason': b'Forbidden'}]
Contributor
There was a problem hiding this comment.
Humph. But the connect call should happen way before the path part of the URL matters, right?
Contributor
Author
There was a problem hiding this comment.
Yep, that's strange. I'm not sure why we can't connect when it comes to robots.txt, while other URLs works. I've reverted the changes and kept only the storage client fix.
| # Use the ApifyStorageClient if the Actor is running on the Apify platform, | ||
| # otherwise use the MemoryStorageClient. | ||
| storage_client = ( | ||
| ApifyStorageClient.from_config(config) if config.is_at_home else MemoryStorageClient.from_config(config) |
Contributor
There was a problem hiding this comment.
This is supposed to happen in Actor.init, right? Why duplicate it here?
Contributor
Author
There was a problem hiding this comment.
Because of the nested event loop, otherwise, it will result in:
RuntimeError: <asyncio.locks.Event object at 0x7c2d640c8fc0 [unset]> is bound to a different event loop
when using Apify client.
janbuchar
approved these changes
Jan 29, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: apify/actor-templates#303