feat: add a few integration tests#48
Merged
Merged
Conversation
github-actions
Bot
added
the
t-core-services
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
drobnikj
marked this pull request as ready for review
February 2, 2023 17:13
drobnikj
commented
Feb 2, 2023
|
|
||
| class TestActorNewClient: | ||
|
|
||
| async def test_actor_new_client_config(self, monkeypatch: pytest.MonkeyPatch) -> None: |
Member
Author
There was a problem hiding this comment.
this test is in helpers, not sure why it was there as well.
fnesveda
approved these changes
Feb 3, 2023
fnesveda
left a comment
fnesveda
left a comment
Member
There was a problem hiding this comment.
Looks good! I just had two small suggestions but they're not too important.
jirimoravcik
approved these changes
Feb 3, 2023
fnesveda
added
the
validated
github-actions
Bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.