feat: Add integration tests for storages, proxy configuration#49
Conversation
github-actions
Bot
added
the
t-core-services
| assert list_page.items[-1]['id'] == desired_item_count - 1 | ||
|
|
||
|
|
||
| class TestActorOpenDataset: |
There was a problem hiding this comment.
I will test if open works for the dataset name and as you pass ID, we probably didn't test this in unit tests.
There was a problem hiding this comment.
We test it with names in unit tests. https://github.com/apify/apify-sdk-python/blob/master/tests/unit/actor/test_actor_dataset.py#L22-L25
| from .conftest import ActorFactory | ||
|
|
||
|
|
||
| class TestActorOpenKeyValueStore: |
There was a problem hiding this comment.
Same here, I would test with name and ID param.
| from .conftest import ActorFactory | ||
|
|
||
|
|
||
| class TestActorOpenRequestQueue: |
There was a problem hiding this comment.
Same here, I would test with name and ID param.
fnesveda
left a comment
fnesveda
left a comment
There was a problem hiding this comment.
Cool! I had a few comments, plus I agree with Kuba's comments about testing the named storages.
| rq1 = await Actor.open_request_queue() | ||
| rq2 = await Actor.open_request_queue() |
There was a problem hiding this comment.
We should also check the RequestQueue class functionality a bit, so that we know it works on the platform.
|
So:
I found out some problems with datetimes, specifically |
fnesveda
added
the
validated
3 participants
I am open to suggestions for more tests or some more complicated cases.
We should also think if running the/same similar code in unit and integration tests has some value or not.