refactor!: Replace httpx with impit#560
Merged
Merged
Conversation
Mantisus
temporarily deployed
to
fork-pr-integration-tests
August 20, 2025 14:17 — with
GitHub Actions
Inactive
Pijukatel
approved these changes
Aug 20, 2025
Mantisus
temporarily deployed
to
fork-pr-integration-tests
August 21, 2025 07:00 — with
GitHub Actions
Inactive
vdusek
temporarily deployed
to
fork-pr-integration-tests
August 21, 2025 08:01 — with
GitHub Actions
Inactive
vdusek
approved these changes
Aug 21, 2025
vdusek
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I just removed the httpx from the dev dependencies, we use the tool.mypy.overrides.ignore_missing_imports for such cases, to avoid bloating the dev dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues