feat: Add chunking mechanism to push_data, cleanup TODOs#67
Merged
Conversation
jirimoravcik
added
adhoc
github-actions
Bot
added
the
t-core-services
fnesveda
requested changes
Feb 13, 2023
fnesveda
left a comment
fnesveda
left a comment
Member
There was a problem hiding this comment.
Nice! I just had one note about the chunking function and some other small notes.
fnesveda
requested changes
Feb 15, 2023
fnesveda
left a comment
fnesveda
left a comment
Member
There was a problem hiding this comment.
Almost there! I just realized a few more things about the chunking.
drobnikj
approved these changes
Feb 15, 2023
Member
|
Just one test is failing @jirimoravcik |
Member
Author
Yeah, I know, looking into it |
fnesveda
added
the
validated
github-actions
Bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds chunking to
push_data, add an integration test for it, cleanup TODOs (issues have been created instead)