fix: prevent void HTML elements from swallowing subsequent content#190
Merged
Conversation
Block-level void elements like <img>, <br>, <input> etc. were treated as opening tags, causing the token processor to consume all subsequent tokens as their children. Skip child scanning for void elements since they never have a matching html_block_close token. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
comark
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
farnabaz
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>,<br>,<input>, etc.) were incorrectly treated as opening tags by the token processor, causing all subsequent content to be nested as their childrenhtml_blockis a void element and returns it immediately without scanning for a matchinghtml_block_closetokenTest plan
<img>and<br>block-level void elements followed by other content<div>still correctly nest their children