Feature/dev 736 translatable alt field#12525
Merged
Merged
Conversation
i-just
marked this pull request as ready for review
November 14, 2023 11:09
# Conflicts: # src/db/Table.php # src/migrations/Install.php [ci skip]
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes assets’ Alt Text fields translatable.
The
altcolumn in theassetstable stays as is and is used for the default alt text. Default alt is one that is saved the first time you add a value to anAltField.A new table -
assets_sites- stores site-specificAltFieldvalues.Translation method/key are set on per volume’s field layout basis.
When you add an
AltFieldvalue for the first time, the default alt (assets.alt) is filled with data. This mimics the behaviour of adding a value to a new e.g. entry. The value is propagated across all sites.Any subsequent changes to the
AltFieldvalue are stored in theassets_sitestable and follow the selected translation method.Related issues
dev-736