Fix assert types#215
Merged
Merged
Conversation
2 tasks
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript typings for fastify.assert() (and its helper methods) to reflect the actual runtime contract: the status code must be provided as the second argument, with an optional message as the third.
Changes:
- Make
codea required parameter (typed asnumber) acrossassert,assert.ok, and related assertion helpers intypes/index.d.ts. - Update
types/index.test-d.tsto use the new required-codecalling patterns.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
types/index.d.ts |
Tightens the Assert function/method signatures to require a status code. |
types/index.test-d.ts |
Updates the type-level tests to call assert APIs with the required status code parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This clarifies that assert can be used with 2-3 arguments, but not with a single argument. The second argument must be the status code as a number.
tmcw
force-pushed
the
issue-214-fix-types
branch
from
March 7, 2026 18:05
f5dcef2 to
69e948b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies that assert can be used with 2-3 arguments, but not with a single argument. The second argument must be the status code as a number.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct